-
Notifications
You must be signed in to change notification settings - Fork 13k
Ensure consistency between the cache state and cached data in DefaultReflectorFactory. #3492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ReflectorFactory.
Hello @izayoiyurin ,
I don't understand why this is necessary.
Usually, class definitions do not change, so there is no point in clearing the cache.
And if, for whatever reason, you want to clear the stale cache, you can just create/set a new instance of DefaultReflectorFactory to the Configuration.
Please let me know if I am missing something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling the cache, an attempt is made to clear all cached Reflector instances. However, complete clearance cannot be strictly guaranteed due to potential concurrent writes.
To ensure that stale data does not affect new cache entries, the cache is proactively cleared again when re-enabling caching.
This change guarantees that once caching is turned back on, it always starts with a clean state, preventing any residual data from the previous caching cycle from being reused.