-
-
Couldn't load subscription status.
- Fork 496
Fixed desync of position on server side when player is dead #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Btw, instead of making pull requests on your fork, you can follow the instructions here.
Microoptimization: you could append the body of the if statement that starts on line 411 to the end of the if statement you changed, because they now check the same condition. That way you surely avoid checking the same condition twice, and reduce 2 lines of code.
Does what it says. Not tested with more than local player, however it fixes #928 and probably(not tested) #908. Should fix most of desyncs when player is dead, because right now client doesn't send any sync when player died.