Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Replace speex with opus #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jushar wants to merge 13 commits into master from feature/opus-voice
Closed

Replace speex with opus #895

jushar wants to merge 13 commits into master from feature/opus-voice

Conversation

@jushar
Copy link
Contributor

@jushar jushar commented Apr 27, 2019 •
edited by StrixG
Loading

Speex was deprecated years ago because opus is in all respects better.

Since this change introduces breaking changes (voice packets are totally different), we have to merge this in a major version.

  • Replace portaudio in favour of using BASS for recording
  • Use opus

If anyone has interest in finishing this, feel free to do so!

Dutchman101, patrikjuvonen, prnxdev, TemaSM, StifflersMom, Disinterpreter, AlexTMjugador, turret001, sudoJ23, theSarrum, and 5 more reacted with thumbs up emoji AlexTMjugador, Wannacry-ops, and Fernando-A-Rocha reacted with heart emoji patrikjuvonen, qaisjp, TemaSM, AlexTMjugador, T-MaxWiese-T, Wannacry-ops, and Fernando-A-Rocha reacted with rocket emoji
@jushar jushar added the enhancement New feature or request label Apr 27, 2019
@jushar jushar added this to the 1.6 milestone Apr 27, 2019
@jushar jushar added the help wanted Extra attention is needed label Apr 27, 2019
Copy link
Contributor

I started working on finishing this a while back at https://github.com/patrikjuvonen/mtasa-blue/tree/libopus but had some memory related crashes at the time, I'll try to look at this one again.

@patrikjuvonen patrikjuvonen changed the title (削除) Replace speex with opus (削除ここまで) (追記) WIP: Replace speex with opus (追記ここまで) May 12, 2019
Copy link

prnxdev commented May 16, 2019

Can't wait to see this working
dmi7ry, Wannacry-ops, and Kinimel reacted with thumbs up emoji

@qaisjp qaisjp changed the title (削除) WIP: Replace speex with opus (削除ここまで) (追記) Replace speex with opus (追記ここまで) May 27, 2019
Copy link
Member

Since this change introduces breaking changes (voice packets are totally different), we have to merge this in a major version.

Do you think we can get this ready for 1.6?
StrixG and Fernando-A-Rocha reacted with thumbs up emoji

@qaisjp qaisjp modified the milestones: 1.5.8, 1.6 Apr 20, 2020
@patrikjuvonen patrikjuvonen added the upstream Related to vendor library label Aug 8, 2020
@botder botder removed this from the 1.6 milestone Feb 3, 2021

This comment has been minimized.

@github-actions github-actions bot added the stale Inactive for over 90 days, to be closed label Jan 7, 2022
@patrikjuvonen patrikjuvonen added keep This pull request is exempt from stale checks and removed stale Inactive for over 90 days, to be closed labels Jan 7, 2022
@patrikjuvonen patrikjuvonen removed their assignment Jun 12, 2023
Copy link

Opus Opus
Fernando-A-Rocha, Wannacry-ops, Armisael2k, FileEX, and Nico8340 reacted with thumbs up emoji

Copy link
Contributor

🧐
Wannacry-ops reacted with thumbs up emoji

Copy link
Member

botder commented Dec 31, 2024

I am going to close this pull request because it's not being maintained and probably requires a fresh start anyway. Anyone can feel free to pick up the effort and create a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request help wanted Extra attention is needed keep This pull request is exempt from stale checks upstream Related to vendor library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /