Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix changing handling max gear to lower than current one crashing client #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qaisjp merged 8 commits into multitheftauto:master from forkerer:gearChangeCrashFix
Feb 10, 2019

Conversation

@forkerer
Copy link
Contributor

@forkerer forkerer commented Jan 15, 2019

Fixes #731
Changing vehicle max gear in handling to lower than current gear used by vehicle resulted in infinite loop in CTransmission:CalculateDriveAcceleration (0x6D05E0), i added a simple check to the beginning of the function, that lowers the gear if it's above maximum limit. The game doesn't freeze anymore.
This snippet helps with testing it:

function veh(client)
	setVehicleHandling(getPedOccupiedVehicle(client), "numberOfGears", 1)
end
addCommandHandler( "veh", veh )

StrixG and Loki214 reacted with thumbs up emoji Loki214 reacted with heart emoji
@forkerer forkerer added the bug Something isn't working label Jan 15, 2019
Copy link

This never happened to me and i changed many max gears on my server, strange.

@qaisjp qaisjp added this to the 1.5.7 milestone Feb 10, 2019
@qaisjp qaisjp self-assigned this Feb 10, 2019
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@qaisjp qaisjp merged commit 5035b7f into multitheftauto:master Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@qaisjp qaisjp qaisjp approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

bug Something isn't working

Projects

None yet

Milestone

1.5.7

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /