- 
 
- 
  Notifications
 You must be signed in to change notification settings 
- Fork 496
Fix changing handling max gear to lower than current one crashing client #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
 
  Merged
 
 
 Conversation
 
 
 This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
 Learn more about bidirectional Unicode characters
 
 
 
 
 
 
 
 
 Einheit-101
 
 
 
 commented
 Jan 29, 2019 
 
 
 
This never happened to me and i changed many max gears on my server, strange.
 qaisjp
 
  
 
 
 qaisjp
 
 
 reviewed
 
 
 Feb 10, 2019 
 
 
 
 
 
 qaisjp
 
  
 
 
 qaisjp
 
 
 reviewed
 
 
 Feb 10, 2019 
 
 
 
 
 
 qaisjp
 
  
 
 
 qaisjp
 
 
 reviewed
 
 
 Feb 10, 2019 
 
 
 
 
 
 qaisjp
 
  
 
 
 qaisjp
 
 
 reviewed
 
 
 Feb 10, 2019 
 
 
 
 
 
 qaisjp
 
  
 
 
 qaisjp
 
 
 reviewed
 
 
 Feb 10, 2019 
 
 
 
 
 
 qaisjp
 
  
 
 
 qaisjp
 
 
 reviewed
 
 
 Feb 10, 2019 
 
 
 
 
 
 qaisjp
 
  
 
 
 qaisjp
 
 
 reviewed
 
 
 Feb 10, 2019 
 
 
 
 
 
 qaisjp
 
  
 
 
 qaisjp
 
 
 reviewed
 
 
 Feb 10, 2019 
 
 
 
 
 
 qaisjp
 
  
 
 
 qaisjp
 
 
 approved these changes
 
 
 Feb 10, 2019 
 
 
 
 
 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:shipit:
 
 Sign up for free
 to join this conversation on GitHub.
 Already have an account?
 Sign in to comment
 
 
 Add this suggestion to a batch that can be applied as a single commit.
 This suggestion is invalid because no changes were made to the code.
 Suggestions cannot be applied while the pull request is closed.
 Suggestions cannot be applied while viewing a subset of changes.
 Only one suggestion per line can be applied in a batch.
 Add this suggestion to a batch that can be applied as a single commit.
 Applying suggestions on deleted lines is not supported.
 You must change the existing code in this line in order to create a valid suggestion.
 Outdated suggestions cannot be applied.
 This suggestion has been applied or marked resolved.
 Suggestions cannot be applied from pending reviews.
 Suggestions cannot be applied on multi-line comments.
 Suggestions cannot be applied while the pull request is queued to merge.
 Suggestion cannot be applied right now. Please check back later.
 
 
 
 
Fixes #731
Changing vehicle max gear in handling to lower than current gear used by vehicle resulted in infinite loop in CTransmission:CalculateDriveAcceleration (0x6D05E0), i added a simple check to the beginning of the function, that lowers the gear if it's above maximum limit. The game doesn't freeze anymore.
This snippet helps with testing it: