-
-
Notifications
You must be signed in to change notification settings - Fork 497
Crashfix #4491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FileEX
merged 3 commits into
multitheftauto:master
from
tederis:fixes/building_crashfix
Sep 24, 2025
Merged
Crashfix #4491
FileEX
merged 3 commits into
multitheftauto:master
from
tederis:fixes/building_crashfix
Sep 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Doesn’t the same problem occur in TestSphereAgainstWorld? Maybe it’s worth fixing it right away in this PR.
mtasa-blue/Client/game_sa/CWorldSA.cpp
Line 544 in e165f6d
ConvertMatrixToEulerAngles(*entity->matrix, result.entityRotation.fX, result.entityRotation.fY, result.entityRotation.fZ);
FileEX
FileEX
previously approved these changes
Sep 23, 2025
Doesn’t the same problem occur in
TestSphereAgainstWorld? Maybe it’s worth fixing it right away in this PR.
That's interesting that testSphereAgainstWorld doesn't cause the crash. But you're right, it should also be fixed.
FileEX
FileEX
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash described in #4490.