Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Limit non-added event logging (#4466) #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dutchman101 merged 2 commits into multitheftauto:master from ArranTuna:client-event-error-limit
Sep 18, 2025

Conversation

@ArranTuna
Copy link
Collaborator

@ArranTuna ArranTuna commented Sep 15, 2025

Only throw an error once per second to prevent flooding from clients triggering non-added server side events.

Only throw an error once per second to prevent flooding.
Copy link
Contributor

Servers should auto-punish a client when they trigger an invalid event (with https://wiki.multitheftauto.com/wiki/OnPlayerTriggerInvalidEvent) so they don't spam at all.
But considering that some servers might not still be doing this, it's probably a good idea to rate-limit the errors thrown on the sever 👍🏼

Copy link
Collaborator Author

ArranTuna commented Sep 15, 2025
edited
Loading

I use that event, but sometimes auto-punish doesn't work and I won't say more on that as it shouldn't be discussed publicly. But this limit will help when auto-punish doesn't work, but also this is good for scripters, say if you've got 100 players on a server and your server side script failed to load, or you forgot to add an event, you could be getting spammed with so many of these errors that you didn't get a chance to see the initial load failure and it's quite a stressful experience. Also onPlayerTriggerInvalidEvent is bad in that case as you could end up auto-punishing innocent players due to a scripting mistake.

Copy link
Contributor

Ok you made valid points. Hundreds of players could trigger the error at the same time.

👍🏼

@FileEX FileEX added the enhancement New feature or request label Sep 16, 2025
@Dutchman101 Dutchman101 merged commit 775d6dd into multitheftauto:master Sep 18, 2025
6 of 7 checks passed
MTABot pushed a commit that referenced this pull request Sep 18, 2025
@botder botder added this to the 1.7.1 milestone Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FileEX FileEX FileEX approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.7.1

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /