-
-
Couldn't load subscription status.
- Fork 496
Fix position desync with dead players (#928) #4453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MohabCodeX
wants to merge
2
commits into
multitheftauto:master
from
MohabCodeX:fix/position-desync-dead-players
Open
Fix position desync with dead players (#928) #4453
MohabCodeX
wants to merge
2
commits into
multitheftauto:master
from
MohabCodeX:fix/position-desync-dead-players
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileEX
FileEX
reviewed
Sep 13, 2025
// player is in.
if (!pSourcePlayer->CanUpdateSync(ucTimeContext))
// player is in. Allow position updates for dead players
if (!pSourcePlayer->CanUpdateSync(ucTimeContext) && !pSourcePlayer->IsDead())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think dead players can be synchronized if the time context doesn't match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohabCodeX Please respond to the feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dead players stopped sending position updates to server, causing
getElementPosition()to return frozen death location instead of current position (e.g., after falling).Fixed by allowing position sync for dead players on both client and server sides.
Results :