-
-
Notifications
You must be signed in to change notification settings - Fork 495
Add ability to make client-side vehicles damageable #4411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to make client-side vehicles damageable #4411
Conversation
I think the createVehicle function has enough arguments. Wouldn't it be wise to make them be damageable with like setVehicleDamageProof false?
I think the createVehicle function has enough arguments. Wouldn't it be wise to make them be damageable with like setVehicleDamageProof false?
It crossed my mind, but I'd still need to have two variables internally anyways... felt silly in that regards. I could of course change the default behavior, but many servers probably wouldn't appreciate that.
I'll see what I can do.
I think the createVehicle function has enough arguments. Wouldn't it be wise to make them be damageable with like setVehicleDamageProof false?
It crossed my mind, but I'd still need to have two variables internally anyways... felt silly in that regards. I could of course change the default behavior, but many servers probably wouldn't appreciate that.
I'll see what I can do.
I could just set the variable that handles damage proof to true by default for a local vehicle.... Okay, I'll make the change
@Fernando-A-Rocha Updated! Your message made me realize the easy solution to making it work through SetVehicleDamageProof. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems ok to me, less complicated than the initial concept 😅 but other devs can share their opinion
Uh oh!
There was an error while loading. Please reload this page.
This PR makes it possible to mark a client-side vehicle to be damageable. By default client-side vehicles cannot receive damage, this PR does not change that default behavior.
When false is passed to SetVehicleDamageProof for a local vehicle, it will now become damageable.