Add setElementCollidableWith server-side #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

Proxy-99 wants to merge 11 commits into multitheftauto:master

from Proxy-99:setCollide

Draft

Add setElementCollidableWith server-side #4101

Proxy-99 wants to merge 11 commits into multitheftauto:master from Proxy-99:setCollide

Conversation

@Proxy-99

Copy link

Contributor

@Proxy-99 Proxy-99 commented Mar 14, 2025 •

edited

Loading

#3681

test code

vehicle1 = createVehicle ( 411, 2044.65942, 1526.35352, 10.67188)
object = createObject( 3578, 2044.40405, 1510.24036, 10.67188)
setTimer(function()
 res = setElementCollidableWith(vehicle1,object,false)
 print(res)
end, 2000, 1)

Proxy-99 added 2 commits

March 14, 2025 12:29

@Proxy-99


 add function serverside

c709597

@Proxy-99


 element checks

97171c1

FileEX

FileEX requested changes

Mar 14, 2025

View reviewed changes

Client/mods/deathmatch/logic/rpc/CElementRPCs.cpp Outdated Show resolved Hide resolved

Client/mods/deathmatch/logic/rpc/CElementRPCs.cpp Outdated

Comment on lines 775 to 776

bitStream.Read(ElementID);

bitStream.ReadBit(bCollidable);

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitStream.Read can return false

Copy link

Member

@TheNormalnij TheNormalnij Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot. The protocol guarantees that the message is fully received.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot. The protocol guarantees that the message is fully received.

So what is the purpose of this function being a bool, and why does most of the code check if it returns true?

Copy link

Member

@TheNormalnij TheNormalnij Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code == documentation
It has sense on the server side. The client reads server packets only.
Checks on client could be used to add a new data to a packet without increasing bitstream version, i think

Client/mods/deathmatch/logic/rpc/CElementRPCs.cpp Outdated Show resolved Hide resolved

Server/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp Show resolved Hide resolved

@Proxy-99


 review fixes

1ba901f

@Proxy-99 Proxy-99 requested a review from FileEX

March 14, 2025 11:42

@TheNormalnij

Copy link

Member

TheNormalnij commented Mar 14, 2025

The function doesn't work for a new connected players and after reconnect

@Proxy-99 Proxy-99 marked this pull request as draft

March 14, 2025 12:10

FileEX

FileEX requested changes

Mar 14, 2025

View reviewed changes

Client/mods/deathmatch/logic/rpc/CElementRPCs.cpp

Comment on lines +781 to +782

if (collidableWith == nullptr) // validity check

return;

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!collidableWith)
 return;

@Proxy-99

Copy link

Contributor Author

Proxy-99 commented Mar 18, 2025

The function doesn't work for a new connected players and after reconnect

What packet file should I write the info?
is it Server\mods\deathmatch\logic\packets\CPlayerJoinCompletePacket.cpp

@FileEX

Copy link

Member

FileEX commented Mar 18, 2025

The function doesn't work for a new connected players and after reconnect

What packet file should I write the info? is it Server\mods\deathmatch\logic\packets\CPlayerJoinCompletePacket.cpp

I think you should store informations on the server side and then send it in the CMapInfoPacket. Check how it's done, for example, with setJetpackWeaponEnabled (CGame::SetJetpackWeaponEnabled & CGame::GetJetpackWeaponEnabled)

Proxy-99 added 8 commits

April 10, 2025 21:30

@Proxy-99


 Merge branch 'master' into setCollide

7a48afd

@Proxy-99


 Merge branch 'master' into setCollide

f72b484

@Proxy-99


 Merge branch 'master' into setCollide

dd1f6a0

@Proxy-99


 Merge branch 'master' into setCollide

64efdd4

@Proxy-99


 adding store data

baf96c3

need to fix elements not loaded to client before calling setColide function or cause crash nullptr since elements does not created to client yet

@Proxy-99


 put it at correct packet

85e37b9

@Proxy-99


 Merge branch 'master' into setCollide

8bf184d

@Proxy-99


 Merge branch 'master' into setCollide

822f0de

Labels

None yet

3 participants

@Proxy-99 @TheNormalnij @FileEX

Uh oh!

Uh oh!

Add setElementCollidableWith server-side #4101

Are you sure you want to change the base?

Add setElementCollidableWith server-side #4101

Uh oh!

Conversation

@Proxy-99 Proxy-99 commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

@FileEX FileEX Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

@TheNormalnij TheNormalnij Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

@FileEX FileEX Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

@TheNormalnij TheNormalnij Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheNormalnij commented Mar 14, 2025

Uh oh!

@FileEX FileEX Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

Proxy-99 commented Mar 18, 2025

Uh oh!

FileEX commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

@Proxy-99 Proxy-99 commented Mar 14, 2025 •

edited

Loading