Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fast Fix for #3900 2 #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
botder merged 4 commits into multitheftauto:master from G-Moris:fix_handling_3424234
Jan 3, 2025
Merged

Conversation

@G-Moris
Copy link
Contributor

@G-Moris G-Moris commented Jan 2, 2025

No description provided.

Copy link
Member

@FileEX FileEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're already on it, wouldn't it be better to rewrite this function using the new parser? It would definitely be more readable

Copy link
Contributor Author

G-Moris commented Jan 2, 2025

Since you're already on it, wouldn't it be better to rewrite this function using the new parser? It would definitely be more readable

I was asked to fix this, I don't really understand the new style of lua functions, but I'll try.

Copy link
Contributor Author

G-Moris commented Jan 2, 2025

I was asked to fix this, I don't really understand the new style of lua functions, but I'll try.

Most likely, it is better to do this in a separate PR, since I was asked to make these changes.

Copy link
Member

tederis commented Jan 2, 2025
edited
Loading

What does exactly this fixes? Or it's a refactor?

Copy link
Contributor Author

G-Moris commented Jan 2, 2025

What does exactly this fixes? Or it's a refactor?

GetHandlingData essentially cannot produce a nullptr

@botder botder merged commit 711c35e into multitheftauto:master Jan 3, 2025
6 checks passed
@botder botder added this to the 1.6.1 milestone Jan 3, 2025
MTABot pushed a commit that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FileEX FileEX FileEX left review comments

@botder botder botder approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /