Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix setVehicleDirtLevel #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dutchman101 merged 6 commits into multitheftauto:master from FileEX:bugfix/vehicle-dirt-level
Dec 14, 2024

Conversation

@FileEX
Copy link
Member

@FileEX FileEX commented Nov 2, 2024

This PR fixes the long-standing non-functional setVehicleDirtLevel function. The code is based on the source code of SilentPatch by CookiePL, also known as Silent.

image
image

PlatinMTA, Proxy-99, Fernando-A-Rocha, sacr1ficez, Weaita, NetroX1993, AlexTMjugador, and lopezloo reacted with heart emoji PlatinMTA, Proxy-99, Fernando-A-Rocha, sacr1ficez, Weaita, T-MaxWiese-T, G-Moris, and NetroX1993 reacted with rocket emoji
Copy link
Contributor

Woww!! Thank you for this. Finally we can start having the amazing GTA:SA fixes the community has created over time, on MTA

Copy link
Contributor

Fixes #3233

Copy link
Contributor

Could we also get a getVehicleDirtLevel? Just because

Fernando-A-Rocha reacted with thumbs up emoji

Copy link
Member Author

FileEX commented Nov 2, 2024

Could we also get a getVehicleDirtLevel? Just because

Yeah but in separate PR

PlatinMTA reacted with thumbs up emoji

Copy link
Contributor

Could we also get a getVehicleDirtLevel? Just because

Makes sense to have. For example in a custom car wash system where you calculate the price based on the dirt

@TheNormalnij TheNormalnij added enhancement New feature or request feedback Further information is requested bugfix Solution to a bug of any kind labels Nov 14, 2024
Review
Co-authored-by: Uladzislau Nikalayevich <thenormalnij@gmail.com>
Copy link
Member

Does it fix setVehicleDirtLevel function only or it makes vehicles to gain dirt over time too?

Copy link
Member Author

FileEX commented Nov 17, 2024

Does it fix setVehicleDirtLevel function only or it makes vehicles to gain dirt over time too?

Probably both cases

Copy link
Member

Nice, ty

Fernando-A-Rocha reacted with heart emoji

@Dutchman101 Dutchman101 merged commit 81218c7 into multitheftauto:master Dec 14, 2024
6 checks passed
MTABot pushed a commit that referenced this pull request Dec 14, 2024
@FileEX FileEX deleted the bugfix/vehicle-dirt-level branch December 14, 2024 12:04
Copy link

Jator-1 commented Dec 21, 2024

This PR probably broke backward compatibility of some shaders. Also after recent update (ver. 22829) texture of vehiclegrunge256 are not correctly displayed on vehicles and components.

Vehicle components probably use now different materials or texture and they are not shown up on shader_tex_names (displayed only on 'chassis' of ZR-350, missing on doors, bonnet, rear bumper, extra1 and whole Premier)
image
image

ver. 22789 - shader works perfectly fine
image (1)
ver. 22829 - shader does not work on vehicle components as bonnet and boot resulting in different shades of paint
image

thealex-br, C0DELEVEL, and Fernando-A-Rocha reacted with thumbs up emoji

Dutchman101 added a commit that referenced this pull request Dec 21, 2024
This reverts commit 81218c7 because of the bugs it caused: see issues #3893 and #3894 
MTABot pushed a commit that referenced this pull request Dec 21, 2024
@FileEX FileEX restored the bugfix/vehicle-dirt-level branch December 28, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TheNormalnij TheNormalnij TheNormalnij left review comments

@TracerDS TracerDS TracerDS requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix Solution to a bug of any kind enhancement New feature or request feedback Further information is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /