Add onClientChatboxLayoutChange event #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

XJMLN wants to merge 7 commits into multitheftauto:master

from XJMLN:feature/onChatboxLayoutChange

Open

Add onClientChatboxLayoutChange event #3448

XJMLN wants to merge 7 commits into multitheftauto:master from XJMLN:feature/onChatboxLayoutChange

Conversation

@XJMLN

Copy link

Contributor

@XJMLN XJMLN commented Jun 9, 2024

Event: onClientChatboxLayoutChange
Description:
Triggered when the client changes any settings related to the chatbox layout.

Parameters:
chatboxLayout: A table containing all CVars values related to the chatbox settings.

Usage Example:

addEventHandler("onClientChatboxLayoutChange", root,
 function(chatboxLayout)
 iprint(chatboxLayout)
 end
)

Resolves #696

@XJMLN


 onClientChatboxLayoutChange event

37b4db3

@Dutchman101 Dutchman101 requested a review from Lpsd

June 30, 2024 03:20

@Dutchman101


 Merge branch 'master' into feature/onChatboxLayoutChange

971e022

Lpsd

Lpsd requested changes

Jul 6, 2024

View reviewed changes

Copy link

Member

@Lpsd Lpsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, just left one comment.

Client/core/CClientChatboxVariables.h Outdated Show resolved Hide resolved

@XJMLN


 code review fix

c95419b

tederis

tederis reviewed

Aug 28, 2024

View reviewed changes

Client/core/CSettings.h Outdated Show resolved Hide resolved

XJMLN and others added 4 commits

August 28, 2024 13:22

@XJMLN


 Merge branch 'master' into feature/onChatboxLayoutChange

6cd65a1

@XJMLN


 fix: separate member variables, add const qualifier

d4253d3

@XJMLN


 fix: const std::string&

009d5b8

@XJMLN


 Merge branch 'master' into feature/onChatboxLayoutChange

7e213bb

Fernando-A-Rocha

Fernando-A-Rocha approved these changes

Nov 6, 2024

View reviewed changes

botder

botder requested changes

Jan 1, 2025

View reviewed changes

Client/core/CSettings.cpp

Comment on lines +3636 to +3637

std::stringstream ss;

ss << std::stof(m_pChatScaleX->GetText()) << " " << std::stof(m_pChatScaleY->GetText());

Copy link

Member

@botder botder Jan 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SString constructor can do printf formatting.

Client/core/CSettings.h

Comment on lines +431 to +432

void SetChatLayoutChanged(bool changed) { m_bChatLayoutChanged = changed; };

bool GetChatLayoutChanged() const { return m_bChatLayoutChanged; };

Copy link

Member

@botder botder Jan 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

void SetChatLayoutChanged(bool changed) { m_bChatLayoutChanged = changed; };

bool GetChatLayoutChanged() const { return m_bChatLayoutChanged; };

void SetChatLayoutChanged(bool changed) { m_bChatLayoutChanged = changed; }

bool GetChatLayoutChanged() const { return m_bChatLayoutChanged; }

Client/mods/deathmatch/CClient.cpp

#define ALLOC_STATS_MODULE_NAME "client"

#include "SharedUtil.hpp"

#include <core/CClientCommands.h>

#include <../Client/core/CClientChatboxVariables.h>

Copy link

Member

@botder botder Jan 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header belongs in Client/sdk/core if you want to interface between core and deathmatch.

Client/mods/deathmatch/CClient.cpp

int iR, iG, iB, iA;

CLuaArguments chatboxItemList;

for (unsigned int i = 0; i < MAX_CHATBOX_LAYOUT_CVARS; i++)

Copy link

Member

@botder botder Jan 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use an array of struct for g_chatboxLayoutCVars, and store the type of value next to the cvar name. For example:

enum class DummyType {
 STRING,
 BOOLEAN,
 FLOAT1,
 FLOAT2,
 FLOAT4,
};
struct Dummy {
 const char* name;
 DummyType type;
};

@FileEX FileEX added enhancement feedback labels

Aug 24, 2025

Labels

enhancement feedback

7 participants

@XJMLN @tederis @Fernando-A-Rocha @botder @Lpsd @FileEX @Dutchman101

Uh oh!

Uh oh!

Add onClientChatboxLayoutChange event #3448

Are you sure you want to change the base?

Add onClientChatboxLayoutChange event #3448

Uh oh!

Conversation

@XJMLN XJMLN commented Jun 9, 2024

Uh oh!

@Lpsd Lpsd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@botder botder Jan 1, 2025

Choose a reason for hiding this comment

Uh oh!

@botder botder Jan 1, 2025

Choose a reason for hiding this comment

Uh oh!

@botder botder Jan 1, 2025

Choose a reason for hiding this comment

Uh oh!

@botder botder Jan 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants