Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update user agent for youtube.com/tv #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrSol0 wants to merge 1 commit into multitheftauto:master from MrSol0:master

Conversation

@MrSol0
Copy link

@MrSol0 MrSol0 commented Jun 3, 2022
edited by patrikjuvonen
Loading

Youtube has once again changed their platform so it no longer supports video resume for most user agents, however roku user agent seems to still work fine with no problems similar to the old user agent.

Youtube has once again changed their platform so it no longer supports video resume for most user agents, however roku user agent seems to still work fine with no problems similar to the old user agent.
@patrikjuvonen patrikjuvonen added the bug Something isn't working label Jun 3, 2022
Copy link
Contributor

Wouldn't it be much more beneficial to set the browser user agent to a custom one via lua in conjunction with setBrowserProperty rather than hardcoding it?

Copy link
Contributor

patrikjuvonen commented Jun 5, 2022
edited
Loading

Wouldn't it be much more beneficial to set the browser user agent to a custom one via lua in conjunction with setBrowserProperty rather than hardcoding it?

It's set by MTA to respect the purpose of user agent header. It is used occasionally by ISPs and services to better understand and route traffic. There isn't any reason to use any other custom user agent than what MTA provides. In this case a part is added which is needed to workaround automatic routing on YouTube. There may be other issues that we don't realize by allowing custom user agents. So for now, no, we're not going to change this behavior.

I'll also need to ask people to stop discussing this in this pull request, because it is off-topic. Please talk over in a new issue or discussion.

AlexTMjugador, Disinterpreter, and lopezloo reacted with thumbs up emoji moon91210 reacted with thumbs down emoji

// Allow YouTube TV to work (#1162)
if (domain == "www.youtube.com" && UTF16ToMbUTF8(urlParts.path.str) == "/tv")
iter->second = iter->second.ToString() + "; SMART-TV; Tizen 4.0";
iter->second = iter->second.ToString() + "; Roku 3/7.0";
Copy link
Contributor

@theSarrum theSarrum Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "Roku 3/7.0" is not enough, so I tried it out and found that we could add "Wireless" and it works.

Suggested change
iter->second = iter->second.ToString() + "; Roku 3/7.0";
iter->second = iter->second.ToString() + "; Roku 3/7.0, Wireless";

Copy link
Member

@lopezloo lopezloo left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current user agent works for me. Please provide more information about this issue.

@lopezloo lopezloo added the feedback Further information is requested label Jul 5, 2022
@MrSol0 MrSol0 closed this Jul 6, 2022
Copy link
Author

MrSol0 commented Jul 6, 2022
edited
Loading

Current user agent works for me. Please provide more information about this issue.

Youtube has restored their old system, the resume is now back again, however i still think "Roku 3/7.0" is better because it has no login page when you resume or watch videos and even no ads!

Copy link
Member

lopezloo commented Jul 6, 2022
edited
Loading

Current user agent works for me. Please provide more information about this issue.

Youtube has restored their old system, the resume is now back again, however i still think "Roku 3/7.0" is better because it has no login page when you resume or watch videos and even no ads!

I still see ads with Roku 3/7.0 UA. What do you mean by saying "resuming videos" and "login page"?

If I visit video URL directly, ex. this one:

https://www.youtube.com/tv#/watch?mode=transport&v=jofNR_WkoCE

I'm getting "who's watching?" page on all user agents, which can be hidden by injecting mouse click.

Copy link
Author

MrSol0 commented Jul 6, 2022
edited
Loading

https://www.youtube.com/tv#/watch?mode=transport&v=jofNR_WkoCE

i have tested https://www.youtube.com/tv#/watch?v=jofNR_WkoCE with user agent as Roku 3/7.0 in chrome and i don't see the who's watching page even with US & UK vpn's, and i mean by resume video this https://www.youtube.com/tv#/watch?v=jofNR_WkoCE&resume&t=120 as an example, it tells you who's watching with other user agents but not with Roku

@MrSol0 MrSol0 reopened this Jul 6, 2022
Copy link
Member

lopezloo commented Jul 6, 2022
edited
Loading

I'm getting this login page even with Roku 3/7.0, Wireless UA. Without Wireless I got redirect to desktop version.

@lopezloo lopezloo changed the title (削除) Updating User agent for youtube.com/tv (削除ここまで) (追記) Update user agent for youtube.com/tv (追記ここまで) Jul 7, 2022
Copy link
Author

MrSol0 commented Jul 7, 2022

I'm getting this login page even with Roku 3/7.0, Wireless UA. Without Wireless I got redirect to desktop version.

It seems like you are using the wrong user agent changer, try use user-agent changer and manager which is a chrome extension. i would also like anyone else to confirm this.

Copy link
Member

Lpsd commented Jul 7, 2022

I'm getting this login page even with Roku 3/7.0, Wireless UA. Without Wireless I got redirect to desktop version.

It seems like you are using the wrong user agent changer, try use user-agent changer and manager which is a chrome extension. i would also like anyone else to confirm this.

Why are you using a Chrome extension for testing this? How can you be sure the request details are exactly the same as in MTA? If you've already accounted for this can you prove it?

lopezloo reacted with thumbs up emoji

Copy link
Contributor

Testing must be done through the MTA client, not external browser.

lopezloo reacted with thumbs up emoji

Copy link
Member

Lpsd commented Jul 7, 2022

It's also worth noting that YouTube generally rolls out their updates/changes slowly, so different users may have different experiences while performing the same actions. This could be down to browser, device, location, IP, account, and many other variables.

lopezloo reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lopezloo lopezloo lopezloo requested changes

+1 more reviewer

@theSarrum theSarrum theSarrum left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working feedback Further information is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /