-
-
Notifications
You must be signed in to change notification settings - Fork 499
0009178: Fix bindKey & unbindKey on commands (2) #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qaisjp
qaisjp
reviewed
Jul 1, 2018
Client/core/CKeyBinds.h
Outdated
bool checkHitState, bool bConsiderDefaultKey = false);
void SetAllCommandsActive(const char* szResource, bool bActive, const char* szCommand = NULL, bool bState = true, const char* szArguments = NULL,
bool checkHitState = false);
bool checkHitState = false, constchar* szOnlyWithDefaultKey = NULL);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should NULL here (and elsewhere) be nullptr?
I think qaisjp meant only use nullptr for the lines you have modified
Done
@patrikjuvonen
patrikjuvonen
changed the title
(削除) #9178 - Fix bindKey & unbindKey on commands (2) (削除ここまで)
(追記) 0009178: Fix bindKey & unbindKey on commands (2) (追記ここまで)
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugtracker:
https://bugs.mtasa.com/view.php?id=9178
Sorry for the last PR and the bug it produced, didn't know about being able to change the key of a bind by yourself.
This PR should fix all the bugs - and the changes are much better than the last time (cause now I can understand why SetAllCommandsActive was used).