Nice!!

I think there is no need for new function svgCreate for files. I think that DxCreateTexture should work with .svg too the same way it works for .png or .jpg. Also OOP support would be nice :)

Integrating into the DX related code would not be good for the overall structure of the API.

svgCreate returns a texture element, CClientVectorGraphic, which can be passed directly to dxDrawImage.

CClientVectorGraphic encapsulates all of the SVG related data, the D3D9 render item and the graphics display class. None of the other dx* functions follow this convention, and in reality they're two completely separate constructs. It would be a mess to implement both features side by side.

Not to mention, we're going to have a LOT of functions with the svg* prefix, to manipulate the SVG document and load data. Somehow, dxCreateSVGDocument doesn't seem right to me?

Have a look into the code, to get a better understand of the implementation.

As briefly discussed on Discord, I think the initial plan should be to roll this out with a few basic functions:

texture/svg svgCreate(width, height [, string pathOrRawData ])
xmlnode svgGetDocumentXML(svg svgElement)
bool svgSetDocumentXML(xmlnode xmlData)

You can create a blank SVG document, supply a file path or read from raw (including xmlnode) data. You can also get the SVG document back as an xmlnode, use the existing xml implementation to edit the xml data, and set it back on the document.

The reason for introducing this simple behaviour at first, is because a proper API will take a lot of time and thought, and will probably be quite an addition to the code. Introducing the basics in this PR, and then the API stuff later, is easier on the reviewer(s).

We can always deprecate svgGet/SetDocumentXML at a later date, once a better API has been introduced.

Thoughts?

Thanks for the review - I've split that code into static, private methods as suggested. In some cases it doesn't cut down the amount of code needed but at least it's more consistent for any future changes.

I've had to format the CLuaShared::GetAsyncTaskScheduler()->PushTask calls by hand, clang-format makes them really ugly if the task function only contains a single line (like a return). Rest should be fine