-
-
Couldn't load subscription status.
- Fork 496
Move version.h and build_overrides.h under Shared folder #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment looks wrong.. the netc.dll made for custom builds (from install-data.bat), which is located at https://mirror.mtasa.com/bdata/netc.dll, should be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the current comment on master (https://github.com/multitheftauto/mtasa-blue/blob/master/Client/version.h#L10)
What would be an accurate fix?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dutchman101 Any comment on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To correct the existing comment(s) that are incorrect.. either in this PR or a new one. Like just refer to the existing build instructions or install-data without specific mention of netc. I would suggest to just refer to the build instructions readme.
Only ccw can merge this
Work done by @qaisjp, moved build_overrides.h under Shared as well as suggested by @ccw808.
As they have minimal differences this makes maintaining easier to have the contents shared between client and server.
Only @ccw808 can merge because this requires build server modifications to support the new build_overrides.h filepath.