- 
 
 - 
  Notifications
 
You must be signed in to change notification settings  - Fork 499
 
Custom train tracks: initial server awareness #1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
 
  Merged
 
 
 qaisjp
 merged 11 commits into
 multitheftauto:master 
from
qaisjp:feature/ctt/initial-server-awareness 
 
 
 
  
 Oct 16, 2020 
 
 
 
  Merged
 
 Custom train tracks: initial server awareness #1715
 qaisjp
 merged 11 commits into
 multitheftauto:master 
from
qaisjp:feature/ctt/initial-server-awareness 
 
 
 
  
 Oct 16, 2020 
 
 Conversation
 
 
 This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
 Learn more about bidirectional Unicode characters
 
 
 
 
 This partially reverts commit 89b5620 (multitheftauto#1713)
 ghost
 
  
 
 
 ghost
 
 
 approved these changes
 
 
 Oct 15, 2020 
 
 
 
 
 
 
 
 @ghost
 
 
 ghost
 
 
 
 left a comment
 
 
 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very happy to see this. Nice work, mate.
 
 Sign up for free
 to join this conversation on GitHub.
 Already have an account?
 Sign in to comment
 
 
 Add this suggestion to a batch that can be applied as a single commit.
 This suggestion is invalid because no changes were made to the code.
 Suggestions cannot be applied while the pull request is closed.
 Suggestions cannot be applied while viewing a subset of changes.
 Only one suggestion per line can be applied in a batch.
 Add this suggestion to a batch that can be applied as a single commit.
 Applying suggestions on deleted lines is not supported.
 You must change the existing code in this line in order to create a valid suggestion.
 Outdated suggestions cannot be applied.
 This suggestion has been applied or marked resolved.
 Suggestions cannot be applied from pending reviews.
 Suggestions cannot be applied on multi-line comments.
 Suggestions cannot be applied while the pull request is queued to merge.
 Suggestion cannot be applied right now. Please check back later.
 
 
 
 
This fully backwards compatible pull request contains initial support for the train track element and the ability to change between default train tracks. This is the first in a series of pull requests that intends to pick apart the
feature/custom-train-tracksbranch in #250, so that it can be confidently reviewed and merged without worrying about bugs too much.You can get default track elements using the below documentation. This documentation is currently only accurate server-side. Client-side it will just return the same number you provide, as clients do not yet have a concept of track elements.
And then set (or get) the track of a train using the following functions:
I have tested sync with one and two players, and track and position syncing seems to work great. The only client changes this PR brings is exposing existing client to the Lua API (a partial revert of 89b5620 / #1713).
The client-side
setTrainTrackfunction is not protected, and can run on server trains. This is consistent with the behaviour ofsetTrainPosition,setTrainDirectionandsetTrainSpeed.Finally, since this code is based on the original
feature/custom-train-tracksbranch:Co-authored-by: Jusonex jusonex96@gmail.com
Co-authored-by: Cazomino05 Cazomino05@gmail.com
Co-authored-by: "sebasdevelopment@gmx.com" sebasdevelopment@gmx.com