-
-
Couldn't load subscription status.
- Fork 496
Fix stack overflow when attaching elements in maps #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request. Seems good to me.
My instinct is that we should (also|only) deal with this in the map parsing/loading process.
(I have only skimmed the code, so I don't know if this change affects performance, and therefore I don't know if the problem should ONLY be dealt with when loading maps.)
My instinct is that we should (also|only) deal with this in the map parsing/loading process.
(I have only skimmed the code, so I don't know if this change affects performance, and therefore I don't know if the problem should ONLY be dealt with when loading maps.)
But it's already working that way. The processes are occuring in function LinkupElements() which in turn invoked inside a map loading process.
Great!
Uh oh!
There was an error while loading. Please reload this page.
When storing elements in maps sometimes we are attaching elements. In that case cross referencing may lead to
an endless cycle and finally to a stack overflow error. The PR is intended to fix it.
The resource for crashing your own server:
test.zip