Search code, repositories, users, issues, pull requests...

Copy link

Contributor

@Unde-R Unde-R commented Sep 7, 2020

Why we need It?

Well looks like we have onVehicleExplode and many other vehicle events but we don't have this one, also as requested in issue #1426, this PR introduces a new event in MTA since not everyone can use cols etc... and It's better than adding a timer or calling onClientRender or something to check if the element isInWater.
(Also this event is triggered for unoccupied vehicles too)

Functionality

 function teteVehicle(thep)
 local x, y, z = getElementPosition(thep)
 teteCar = createVehicle(411, x+2, y, z)
 addEventHandler("onVehicleDrown", teteCar, function()
 outputChatBox("rip Tete car")
 end)
 end
 addCommandHandler("tetecar", teteVehicle)

This event is triggered when a vehicle drowns.

Screenshots

tete

Unde-R added 2 commits

September 7, 2020 13:33


 Declaring the Event

d544f31


 Calling the event once in water

8b2dfed

Copy link

Member

TheNormalnij commented Sep 7, 2020

I think that this event need to be complex. I see this like a onElementWaterInteract what will works with peds, vehicles and objects (maybe) and has bWaterInOrOut parameter.

Copy link

Contributor Author

Unde-R commented Sep 7, 2020

for objects not worth it.
We'll need to get a proper event name

Copy link

Contributor Author

Unde-R commented Sep 8, 2020

@qaisjp any ideas?

@StrixG StrixG added the enhancement label

Sep 11, 2020

Pirulax

Pirulax requested changes

Sep 12, 2020

Server/mods/deathmatch/logic/CUnoccupiedVehicleSync.cpp Outdated

Comment on lines 423 to 424

CLuaArguments Arguments;

pVehicle->CallEvent("onVehicleDrown", Arguments);

Copy link

Contributor

@Pirulax Pirulax Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a convention in the code more or less, afaik.
But I'd use {} there, or CLuaArguments() (but {} should work)
Not even sure why CallEvent doesn't default construct CLuaArguments

Server/mods/deathmatch/logic/packets/CVehiclePuresyncPacket.cpp Outdated

Comment on lines 161 to 162

CLuaArguments Arguments;

pVehicle->CallEvent("onVehicleDrown", Arguments);

Copy link

Contributor

@Pirulax Pirulax Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

StrixG

StrixG reviewed

Oct 19, 2020

Server/mods/deathmatch/logic/CGame.cpp Outdated Show resolved Hide resolved

@Unde-R @StrixG


 Update Server/mods/deathmatch/logic/CGame.cpp

099fec9

Co-authored-by: Nikita Obrekht <obrekht@gmail.com>

ghost

ghost reviewed

Oct 20, 2020

Server/mods/deathmatch/logic/CVehicle.h Outdated Show resolved Hide resolved

Server/mods/deathmatch/logic/CVehicle.cpp Outdated Show resolved Hide resolved

qaisjp

qaisjp suggested changes

Oct 20, 2020

Copy link

Contributor

@qaisjp qaisjp left a comment •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this event need to be complex. I see this like a onElementWaterInteract what will works with peds, vehicles and objects (maybe) and has bWaterInOrOut parameter.

I agree with @TheNormalnij's comment (copied above, from here: #1657 (comment))

This onVehicleDrown event doesn't look like it's detecting when a vehicle drowns, but when it interacts with water. Changing the event name now would make this a matter of finding a reason to merge code that accidentally doesn't work as intended.

Please create an issue proposing what feature you want to implement. In that issue, once we've discussed the what the feature should look like, we can discuss whether the code here is appropriate for that. In your issue, please try and provide answers to the questions written here. (Yes, it's a link to Windows Calculator's repo. See #887 for more context on what a "proposal" means.)

Unde-R and others added 3 commits

October 20, 2020 21:34


 Update Server/mods/deathmatch/logic/CVehicle.h

4426e51

Co-authored-by: saml1er <10183157+saml1er@users.noreply.github.com>


 Update Server/mods/deathmatch/logic/CVehicle.cpp

dae5ef3

Co-authored-by: saml1er <10183157+saml1er@users.noreply.github.com>


 Update Server/mods/deathmatch/logic/CVehicle.h

71d145a

Co-authored-by: saml1er <10183157+saml1er@users.noreply.github.com>

Copy link

Contributor Author

Unde-R commented Oct 28, 2020

I think that this event need to be complex. I see this like a onElementWaterInteract what will works with peds, vehicles and objects (maybe) and has bWaterInOrOut parameter.

I agree with @TheNormalnij's comment (copied above, from here: #1657 (comment))

This onVehicleDrown event doesn't look like it's detecting when a vehicle drowns, but when it interacts with water. Changing the event name now would make this a matter of finding a reason to merge code that accidentally doesn't work as intended.

Please create an issue proposing what feature you want to implement. In that issue, once we've discussed the what the feature should look like, we can discuss whether the code here is appropriate for that. In your issue, please try and provide answers to the questions written here. (Yes, it's a link to Windows Calculator's repo. See #887 for more context on what a "proposal" means.)

sure even if #1426 exists?

Copy link

Member

TheNormalnij commented Oct 28, 2020

GTA SA store IN_WATER state in physical flags. You can add onClientElementPhysicalStateChanged ( oldState, newState ) for peds/vehicles/obejct. oldState - physical flags before GTA call ProcessControl, newState - after ProcessControl. You can find ProcessControl hooks in multiplayer_keysync.cpp


 Rename to onElementWaterInteract and support for objects/peds

6a3790e

Copy link

Member

TheNormalnij commented Oct 31, 2020

If you want to add serverside event, you don't need save last isWater state.

if (flags.data.bIsInWater != pVehicle->IsInWater())
{
 ...
}

Correct me if it's wrong

Copy link

Contributor Author

Unde-R commented Oct 31, 2020

If you want to add serverside event, you don't need save last isWater state.
if (flags.data.bIsInWater != pVehicle->IsInWater())
{
 ...
}
Correct me if it's wrong

cheers gonna try I've seen flag code somewhere I'll try it