-
-
Notifications
You must be signed in to change notification settings - Fork 496
Fix #1279: driveby for peds #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qaisjp
qaisjp
approved these changes
Mar 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments, but it works and the code looks good.
@qaisjp
qaisjp
added
feedback
Further information is requested
bug
Something isn't working
labels
Mar 14, 2020
Co-Authored-By: Qais Patankar <qaisjp@gmail.com>
@qaisjp
qaisjp
changed the title
(削除) Fix #1279 driveby for peds (削除ここまで)
(追記) Fix #1279: driveby for peds (追記ここまで)
Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #1279
Driveby shooting didn't work for peds because ped target vectors are not updated (Ped::Interpolate) when he's in a vehicle. This is fixed by using Ped::SetAimingData instead of Ped::SetTargetTarget.
All 4 driveby aim animations now work.
Ped target origin is currently ped position instead of gun muzzle, so bullets appear to shoot from center of ped. I've changed it to gun muzzle, I don't think this should break any scripts?