-
-
Couldn't load subscription status.
- Fork 496
Cleanup redundant checks #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm I don't understand why my setPedStat commits are in this when I created a cleanup branch specifically for the redundant checks.
It is because you commited it to master branch in your previous pull request #106 and you haven't synced your fork's master with upstream (it is recommended to do it before starting any bigger work, details here: https://help.github.com/articles/syncing-a-fork/). The simplest way to fix it is to do interactive rebase in order to drop this single commit from your branch, and then do force push. Pull request should be automatically updated after that. To avoid this complication in the future just remember not to commit to master :)
Good job BTW
I don't understand how to delete those commits from this PR.
Type git rebase -i HEAD~7 and change the word in front of the commits you want to remove to drop.
Then do git push force
Saved 286 lines by removing redundant if ( pPed )'s and their LogBadPointer's as this is already handled by argStream.
Weren't many to remove from the server it seems.
Wow, that actually worked, thank you.
Thank you! For future commits please write your messages in good form.
Removed all the redundant checks such as if ( pVehicle ) { .... } else m_pScriptDebugging->LogBadPointer ( luaVM, "vehicle", 1 );