Skip to content

chore: add eslintcache #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Simon-He95 wants to merge 1 commit into msgbyte:master from Simon-He95:master

Closed

chore: add eslintcache #56

Simon-He95 wants to merge 1 commit into msgbyte:master from Simon-He95:master

Conversation

Copy link

@Simon-He95 Simon-He95 commented Dec 5, 2022

No description provided.


 chore: add eslintcache

b2deee2

Copy link

Contributor

moonrailgun commented Dec 5, 2022

为什么需要增加cache呢?他的收益是?

Copy link

Author

Simon-He95 commented Dec 5, 2022

为什么需要增加cache呢?他的收益是?

https://gist.github.com/banyudu/e69fb0221743e6e824ea027d4c473675

Copy link

Contributor

moonrailgun commented Dec 5, 2022

这篇文章我看了,老实说不是很认可。缓存想要命中,特别是在scm系统中,意味着每次提交代码都会带上一个变更的cache文件,对于scm来说是很难接受的(额外的噪音)
但是他的收益也不是很大(缓存可以加快速度,其他没了),如果他是一种收益大于成本的行为的话,相信eslint会将其作为默认项配置的(类似jest,babel等)
这个pr我关闭了

@moonrailgun moonrailgun closed this

Copy link

Author

Simon-He95 commented Dec 5, 2022

.eslintcache is not pushed in .gitignore. just in your local :)

Copy link

Contributor

moonrailgun commented Dec 5, 2022

本地在大多数时间不会全量运行eslint。通过commitlint只会运行少量的几个(另外在editor中可以自行保证之检查有限的几个文件)。不需要缓存

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment