Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add new profile finder method for chromium and firefox #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moonD4rk wants to merge 4 commits into dev
base: dev
Choose a base branch
Loading
from feat/profile

Conversation

@moonD4rk
Copy link
Owner

@moonD4rk moonD4rk commented Nov 23, 2024

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit, build tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

- Refactored variable declarations in log package for improved readability and consistency
- Removed redundant code and unnecessary parentheses in logger_test.go
- Simplified variable assignment in logger.go for better code maintainability
@moonD4rk moonD4rk changed the base branch from main to dev November 23, 2024 16:37
@moonD4rk moonD4rk self-assigned this Nov 23, 2024
@moonD4rk moonD4rk marked this pull request as ready for review November 23, 2024 16:38
Copy link

coveralls commented Nov 23, 2024
edited
Loading

Pull Request Test Coverage Report for Build 12002556121

Details

  • 24 of 233 (10.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.8%) to 35.522%

Changes Missing Coverage Covered Lines Changed/Added Lines %
profile/filesystem.go 0 3 0.0%
profile/profile.go 0 43 0.0%
filemanager/filemanager.go 8 83 9.64%
profile/finder.go 15 103 14.56%
Totals Coverage Status
Change from base Build 11854253557: -6.8%
Covered Lines: 395
Relevant Lines: 1112

💛 - Coveralls

moonD4rk and others added 2 commits November 25, 2024 00:04
- Added error handling for missing master key and data files in profile package
- Introduced error variables for missing files in profile package
- Implemented validation function for checking presence of master key and data files in profile package
- Created FileManager type for managing temporary file operations in filemanager package
- Implemented methods for copying profiles, copying profile data, and cleaning up temporary files in FileManager type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /