-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-493: Unified test runner POC #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8b71737 to
02509b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review. As per request, I've skipped reviewing the ExpectedError, ExpectedResult, and Operation classes.
8625946 to
08e8303
Compare
Includes patch from #790 for CreateIndexes.
Also syncs spec tests with mongodb/specifications#846, all of which are currently passing locally on replica set and sharded clusters. We'll see what Travis and Evergreen say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this will only be relevant once we port over more tests to the new format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may actually never come up unless a test actually asserts that a cursor ID is zero and a 32-bit PHP platform tries to compare 0 with Int64(0). I think you could probably punt on this until it actually becomes an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
21f5dbc to
ccec13d
Compare
33b1352 to
f21efac
Compare
https://jira.mongodb.org/browse/PHPLIB-493