-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-114: Implement GridFS specification #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/GridFS/StreamWrapper.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug typo alert
0e70913 to
56023b0
Compare
2cc8b96 to
22e0480
Compare
src/GridFS/BucketReadWriter.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fold this class and its methods into the Bucket class, since that's where the spec expects to find these methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class still exists, but is no longer called from anywhere. Just keeping it around until we're sure we're done with it.
PHPLIB-114: CS fixes and refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #57 (comment), I think we should default $filter to an empty array.
391f6af to
87d08a6
Compare
prolic
commented
Feb 4, 2016
Can't wait for it ;) Good work!
prolic
commented
Feb 4, 2016
Any benchmarks for performance comparison from this lib to usage with legacy driver grid fs implementation?
@prolic: Not yet. We're certainly aiming to do some before this gets released in 1.1. There is actually a cross-driver benchmark specification that @derickr has started implementing for the old/new drivers, which also includes tests for GridFS operations.
I'm currently preoccupied with fixing some PHPC issues (as is @derickr with getting HHVM 1.1.0 released); however, I should be returning to PHPLIB work once PHPC 1.1.3 is released and this is high on my list to merge down and begin cleaning up and benchmarking.
rexxars
commented
Mar 1, 2016
Anything we can do to progress this PR any further? Library doesn't feel complete without GridFS support...
edast
commented
Mar 2, 2016
do you have preliminary date, when this PR will be merged?
Manually merged in aef27f0, which is now the 1.1.x-dev branch alias. I still intend to take another pass at the merged code and apply some refactoring before a 1.1.0 release (no ETA on that), but it's technically merged if you would like to experiment with it.
* Allow to merge an array of stages into a pipeline * Improve types * Add test to create pipeline from array
https://jira.mongodb.org/browse/PHPLIB-114