-
Notifications
You must be signed in to change notification settings - Fork 266
Upload evergreen test results to codecov.io #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## v2.x #1736 +/- ## ========================================= Coverage 87.54% 87.54% Complexity 3182 3182 ========================================= Files 423 423 Lines 6336 6336 ========================================= Hits 5547 5547 Misses 789 789
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3a4b6e4 to
9ad2fff
Compare
.evergreen/config/functions.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this isn't be pulled from a repository, it'd be prudent to integrity check the binary. I noted this didn't apply to the earlier GitHub Action integration (ae31f00) since you just reference their action (codecov/test-results-action).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the shasum check for the time being. I can add the gpg signature check for the checksum file as well, but with evergreen sharing hosts between runs I'm not sure if we should be messing with the keychain.
.evergreen/config/functions.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this necessary? $MONGODB_VERSION and $TOPOLOGY should already be available in the environment, since they're referenced in the previous shell.exec command. The inclusion of cat here also looks like it may be leftover debugging.
Based on the comment below, expansions.update was only necessary to add
MONGODB_URI and CRYPT_SHARED_LIB_PATH, which are written in drivers_orchestration.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MONGODB_VERSION and TOPOLOGY are passed as variables to the bootstrap mongo-orchestration function only, so they are no longer available later in the run. Adding them to the expansion file created by the script allows us to reuse the values later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this reference a variable from the Evergreen project config? I didn't see this when taking a look at the PHPLIB 2.x project settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason uploading the test result file worked even without a token. I have added it to the repo variables nonetheless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I think it's worth defining the variable, especially since the argument isn't quoted. If it resolves to nothing that could lead to some unexpected behavior for the --token option.
In order to better use the flaky test feature of codecov.io, this PR adds a step to upload the test result file to codecov.io, as is already done for GitHub Actions.