-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-1654: Support new $concatArrays and $setUnion aggregation accumulators
#1732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPLIB-1654: Support new $concatArrays and $setUnion aggregation accumulators
#1732
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@ ## v2.x #1732 +/- ## ============================================ - Coverage 87.57% 87.54% -0.04% - Complexity 3174 3182 +8 ============================================ Files 421 423 +2 Lines 6320 6336 +16 ============================================ + Hits 5535 5547 +12 - Misses 785 789 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor comment.
Looking at the coverage, it's missing tests for exceptions when providing invalid arguments. We can leave those out for the time being and I'd rather add some kind of semi-automated testing like we have for operation classes (see this code for an example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, our code from discussing different ways to write agg pipelines found its way in here. I'll let you decide whether you want to keep it this way or inline it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked this :)
Closes PHPLIB-1654
Does what it says on the tin.