-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-1378 Replace example printfs with a callable #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@paulinevos
paulinevos
changed the title
(削除) Replace example printfs with a callable (削除ここまで)
(追記) PHPLIB-1378 Replace example printfs with a callable (追記ここまで)
Jun 4, 2025
@paulinevos
paulinevos
force-pushed
the
1378_replace-printf-calls
branch
2 times, most recently
from
June 4, 2025 15:07
f9cf53a to
ca244cb
Compare
alcaeus
alcaeus
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Failing tests were fixed in #1712, so rebasing on top of v2.x should fix the broken build.
To make it easier for users to work off the examples without having to replace all the print statements
@paulinevos
paulinevos
force-pushed
the
1378_replace-printf-calls
branch
from
June 5, 2025 08:57
ca244cb to
cc7979f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
PHPLIB-1378
To make it easier for users to work off the examples without having to replace all the print statements