-
Notifications
You must be signed in to change notification settings - Fork 266
DOCSP-36027: Shorten class headings backport (#1229) #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-36027: Shorten class headings backport (#1229) #1236
Conversation
Also consolidates result classes to a single section (cherry picked from commit 00d44d4)
All of the following pages have scrolling issues where the page is left below the start of content:
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBBulkWriteResult-isAcknowledged/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBChangeStream-key/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBChangeStream-next/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/
reference/method/MongoDBChangeStream-rewind/ - https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelCollectionInfo-getCappedSize/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelCollectionInfo-getIdIndex/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelCollectionInfo-getInfo/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelDatabaseInfo-getName/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelDatabaseInfo-getSizeOnDisk/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/class/MongoDBModelDatabaseInfoIterator/
This may not be an exhaustive list, but it's what I collected from poking through the preview URL.
This came up previously in #1229 (comment) but there doesn't appear to be any conclusive solution there (I think you just worked around it). Let me know if you're OK merging this as-is or if there's something you want to adjust.
All of the following pages have scrolling issues where the page is left below the start of content:
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBBulkWriteResult-isAcknowledged/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBChangeStream-key/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBChangeStream-next/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/
reference/method/MongoDBChangeStream-rewind/- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelCollectionInfo-getCappedSize/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelCollectionInfo-getIdIndex/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelCollectionInfo-getInfo/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelDatabaseInfo-getName/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/method/MongoDBModelDatabaseInfo-getSizeOnDisk/
- https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/reference/class/MongoDBModelDatabaseInfoIterator/
This may not be an exhaustive list, but it's what I collected from poking through the preview URL.
This came up previously in #1229 (comment) but there doesn't appear to be any conclusive solution there (I think you just worked around it). Let me know if you're OK merging this as-is or if there's something you want to adjust.
I'm not seeing the same problem, although I brought it up to my team and one person was able to reproduce it. I also sent a message to DOP - here's the Slack thread if you want to take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to leave as-is.
Merged up to v1.17 in f454abd. This required adding back some content from 00d44d4 for methods introduced in 1.17+, which you correctly removed from the backport commit in this PR.
I then merged up v1.17 to master in 890ad37, which was mostly a no-op but added some missing newlines at the end of two files.
Uh oh!
There was an error while loading. Please reload this page.
Also consolidates result classes to a single section
(cherry picked from commit 00d44d4)
JIRA - https://jira.mongodb.org/browse/DOCSP-36027
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36027-backport/