-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-1194: Test log message for non-genuine hosts #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only relevant class in the PR. Everything else is from #1158.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: not using named data providers was intentional, since it would have involved a lot of redundancy. I only added comments to notable test cases from my original libmongoc tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these tests run in CI with a CosmoDB server?
Do these tests run in CI with a CosmoDB server?
No. These aren't integration tests, as the logic for emitting these log messages is entirely client-side.
ead89cd to
2208186
Compare
2208186 to
ed901e7
Compare
https://jira.mongodb.org/browse/PHPLIB-1194
Depends on #1158