-
Notifications
You must be signed in to change notification settings - Fork 211
PHPC-1017: Allow configure options to be specified with PECL install #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a note that "yes" results in automatic detection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using "yes" (the binary) would also mean: system libbson, system libmongoc, and system-chiphers. I don't think we should recommend that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may also warrant a note that it's for OpenSSL. Perhaps "OpenSSL: Use system default..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmikola so in the future, it's yes | pecl install mongodb? Good thing it's 24pullrequests time :)
so in the future, it's
yes | pecl install mongodb?
I think so. I recall having to do something similar when installing the legacy driver on Travis due to: https://github.com/mongodb/mongo-php-driver-legacy/blob/3321e9849a3d17503707ded728586ce34d69fb69/package.xml#L212-L214
Using "yes" (the binary) would also mean: system libbson, system libmongoc, and system-chiphers. I don't think we should recommend that?
@alcaeus: @derickr raised a good point above. I think we'll need to rework this a bit.
@derickr: I'm reminded that #659 was only asking about exposing --with-openssl-dir for use by Homebrew on macOS. That may be moot if PHPC-888 is implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rethink.
Won't Fix.
@BJGDEV
BJGDEV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Uh oh!
There was an error while loading. Please reload this page.
https://jira.mongodb.org/browse/PHPC-1017
Added the configurations to the
package.xml.infile, and also align the options in./configure --help(it's been bugging me for a while).