-
Couldn't load subscription status.
- Fork 211
PHPC-2638 and PHPC-2630: Bump to libmongoc 2.1.2 and libmongocrypt 1.16.0 #1868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7fe0f9e to
3f7be27
Compare
990c7fe to
a79eab9
Compare
Note: we've got two regularly failing builds on Windows 8.4 x86 (nts and ts) due to:
C1060: compiler is out of heap space
The most recent failures are at mongoc-handshake.c:702 but I'm not sure how pertinent that is. Will come back to this and investigate further.
a79eab9 to
13515f7
Compare
This pulls in changes from MONGOCRYPT-845, which are necessary to produce a static build with both libmongoc 2.1.x and libmongocrypt (due to a conflict in the "mlib" headers).
9126259 to
2f95be6
Compare
7a3346a to
e398106
Compare
.gitmodules
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the fix you added on your branch necessary for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still attempting to isolate the OOM compiler error in order to provide meaningful feedback to the C team. It's likely this is the result of ludicrous macro expansion in their BSON DSL (see mongoc-handshake.c in mongodb/mongo-c-driver@f142c61).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quoting How to: Enable a 64-Bit, x64 hosted MSVC toolset on the command line:
If you run into memory limits when you use the 32-bit tools, try the 64-bit tools.
Hat tip to @kevinAlbs.
This should avoid memory limits when using 32-bit tools, which is relevant for libmongoc sources using the BSON DSL API. If you run into memory limits when you use the 32-bit tools, try the 64-bit tools.
0543a2f to
d6ab8c9
Compare
Uh oh!
There was an error while loading. Please reload this page.
https://jira.mongodb.org/browse/PHPC-2638
https://jira.mongodb.org/browse/PHPC-2630
The libmongocrypt upgrade is necessary due to a collision between "mlib" headers in libmongoc and libmongocrypt (addressed in MONGOCRYPT-845).