PHPC-2510 Install evergreen tools using git submodule #1797

Updated .evergreen/README.md to reflect the new installation method.
Changed the description to indicate that the package is installed as a Git submodule in the tests repository.

Files not reviewed (6)

.evergreen/config/functions.yml: Language not supported
.github/dependabot.yml: Language not supported
.github/workflows/tests.yml: Language not supported
.github/workflows/windows-tests.yml: Language not supported
.gitmodules: Language not supported
tests/drivers-evergreen-tools: Language not supported

@GromNaN GromNaN requested review from alcaeus, Copilot and jmikola

March 18, 2025 18:14

Copilot AI reviewed

Mar 18, 2025

View reviewed changes

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the installation instructions for evergreen tools, switching from cloning during the build process to using a Git submodule.

Updated README in the .evergreen directory with new installation instructions.
Clarified that the evergreen tools package is now installed as a Git submodule in the tests repository.

Files not reviewed (6)

.evergreen/config/functions.yml: Language not supported
.github/dependabot.yml: Language not supported
.github/workflows/tests.yml: Language not supported
.github/workflows/windows-tests.yml: Language not supported
.gitmodules: Language not supported
tests/drivers-evergreen-tools: Language not supported

GromNaN

GromNaN commented

Mar 18, 2025

View reviewed changes

.evergreen/config/functions.yml Outdated

else

git clone https://github.com/mongodb-labs/drivers-evergreen-tools.git $DRIVERS_TOOLS

git submodule update --init --depth 1

Copy link

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --depth 1 was not in PHPLIB. I can add it also to reduce the Git history that get downloaded.

Copy link

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to revert this change, there is a git checkout inside the libmongoc submodule when LIBMONGOC_VERSION is set (always). Maybe I can fetch the tag directly.

mongo-php-driver/.evergreen/config/functions.yml

Lines 139 to 145 in bf34d5b

working_dir: "src/src/libmongoc"

add_expansions_to_env: true

script: |

if [ -n "${LIBMONGOC_VERSION}" ]; then

echo "Checking out libmongoc version: ${LIBMONGOC_VERSION}"

git fetch

git checkout ${LIBMONGOC_VERSION}

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you could initialize the submodules independently by passing their path as an argument to git submodule update, although that would make this more fragile if additional submodules are introduced to the project.

Assuming it works, fetching the tag for libmongoc does seem more resilient, and then you could keep that logic local to the LIBMONGOC_VERSION handling.

@GromNaN

Copy link

Member Author

GromNaN commented Mar 18, 2025

I don't understand the evergreen errors.

[2025年03月18日 19:13:21.723] From https://github.com/mongodb/mongo-c-driver
[2025年03月18日 19:13:21.723] * [new tag] 1.30.1 -> 1.30.1
[2025年03月18日 19:13:21.727] Checking out libmongoc version: r1.30
[2025年03月18日 19:13:21.727] error: pathspec 'r1.30' did not match any file(s) known to git
[2025年03月18日 19:13:21.727] Command 'shell.exec' in function 'compile driver' (step 1.1 of 2) failed: shell script encountered problem: exit code 1.
[2025年03月18日 19:13:21.727] Finished command 'shell.exec' in function 'compile driver' (step 1.1 of 2) in 504.58684ms.

[2025年03月18日 19:16:10.592] 2025年03月18日 18:16:10,239 [DEBUG] mongo_orchestration.process:158 - process is not alive
[2025年03月18日 19:16:10.592] 2025年03月18日 18:16:10,239 [ERROR] mongo_orchestration.servers:389 - Could not start Server. Please find server log below.
[2025年03月18日 19:16:10.592] =====================================================
[2025年03月18日 19:16:10.592] 2025年03月18日 18:16:10,240 [ERROR] mongo_orchestration.servers:393 - {"t":{"$date":"2025-03-18T18:16:10.157+00:00"},"s":"E", "c":"NETWORK", "id":23248, "ctx":"-","msg":"Cannot read certificate file","attr":{"keyFile":"/data/mci/826c701ecd806ff38ce7df3bae7a2e8b/src/tests/drivers-evergreen-tools/.evergreen/x509gen/server.pem","error":"error:02001002:system library:fopen:No such file or directory"}}
[2025年03月18日 19:16:10.592] {"t":{"$date":"2025-03-18T18:16:10.157+00:00"},"s":"D1", "c":"-", "id":23074, "ctx":"-","msg":"User assertion","attr":{"error":"InvalidSSLConfiguration: Can not set up PEM key file.","file":"src/mongo/util/net/ssl_manager_openssl.cpp","line":2582}}
[2025年03月18日 19:16:10.592] {"t":{"$date":"2025-03-18T18:16:10.157+00:00"},"s":"F", "c":"CONTROL", "id":20574, "ctx":"-","msg":"Error during global initialization","attr":{"error":{"code":140,"codeName":"InvalidSSLConfiguration","errmsg":"Can not set up PEM key file."}}}
[2025年03月18日 19:16:10.592] 2025年03月18日 18:16:10,240 [ERROR] mongo_orchestration.apps:68 - <function sh_create at 0x7f069a36d1b0>

jmikola

jmikola approved these changes

Mar 19, 2025

View reviewed changes

Copy link

Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions you can address on your own.

.github/dependabot.yml Show resolved Hide resolved

.evergreen/README.md Outdated Show resolved Hide resolved

alcaeus

alcaeus approved these changes

Mar 24, 2025

View reviewed changes

GromNaN and others added 5 commits

April 11, 2025 09:03

@GromNaN


 PHPC-2510 Install evergreen tools using git submodule

Update drivers-evergreen-tools

@GromNaN @jmikola


 Update .evergreen/README.md

90b6920

Co-authored-by: Jeremy Mikola <jmikola@gmail.com>

@GromNaN


 Track submodule precisely

81bdd27

@GromNaN


 Full history must be fetched

90e7904

@GromNaN


 Update submodule

6715e01

@GromNaN GromNaN force-pushed the PHPC-2510 branch from f0f93f1 to 6715e01 Compare

April 11, 2025 07:04

@alcaeus


 Fix paths for drivers-evergreen-tools when fetching build

084bb1d

@alcaeus alcaeus requested a review from a team as a code owner

May 19, 2025 14:14

@alcaeus alcaeus merged commit 704f914 into mongodb:v1.x

May 19, 2025

60 checks passed

@mongodb-php-bot mongodb-php-bot mentioned this pull request

May 19, 2025

Merge v1.x into v2.0 #1825

Merged

@GromNaN GromNaN deleted the PHPC-2510 branch

May 19, 2025 14:40

@mongodb-php-bot mongodb-php-bot mentioned this pull request

May 19, 2025

Merge v2.0 into v2.x #1826

Merged

alcaeus added a commit that referenced this pull request

Jun 12, 2025

@alcaeus


 Resolve conflicts

750a5e1

* v2.1: (37 commits)
 Back to -dev
 Package 2.1.0
 PHPC-2555: Stop testing with MongoDB 4.0 (#1827)
 PHPC-2510 Install evergreen tools using git submodule (#1797)
 Bump to libmongoc 1.30.4 (#1822)
 Feature: Client Bulk Write (#1818)
 Mention Serializable/Unserializable types in upgrade guide (#1805)
 Back to -dev
 Package 2.0.0
 Master is now 2.1-dev
 PHPC-2536: Remove run-ocsp-responder.sh (#1802)
 PHPC-2536: Migrate to common OCSP responder script (#1800)
 1.x is now 1.22.0dev
 PHPC-2485: Remove WriteConcern and ReadPreference from execute method arginfo (#1783)
 PHPC-2497: BulkWriteException stub should inherit ServerException (#1784)
 PHPC-2441: Remove deprecated Manager constructor options (#1719)
 PHPC-990: Strict type validation for boolean URI options (#1713)
 PHPC-2440: Remove deprecated Query constructor options (#1707)
 PHPC-2459: Remove support for float arg in UTCDateTime ctor (#1709)
 Remove obsolete test
 ...

Labels

None yet

3 participants

@GromNaN @jmikola @alcaeus

PHPC-2510 Install evergreen tools using git submodule #1797

PHPC-2510 Install evergreen tools using git submodule #1797

Uh oh!

Conversation

@GromNaN GromNaN commented Feb 26, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

@GromNaN GromNaN Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

@GromNaN GromNaN Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

@jmikola jmikola Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

GromNaN commented Mar 18, 2025

Uh oh!

@jmikola jmikola left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants