-
Notifications
You must be signed in to change notification settings - Fork 211
PHP 7 for Phongo - A New Hope. #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSRMLS_FETCH_FROM_CTX() still dose the assignment in PHP7, which leads to compiler warning since we don't actually use it
This simplifies calling bson_to_zval() quite a bit. bson_to_zval() now takes empty zval* bson_to_zval_ex() now takes php_phongo_bson_state (with empty zval*) bson_to_zval() will always alloc and init state.zchild
Refactor so it mimicks all the other <type>_to_zval() Also gets rid of MAKE_STD_ZVAL() for PHPC-373
Since ADD_ASSOC_STRINGL() always duplicates, use a static buffer in UTCDateTime's debug handler when converting milliseconds to a string on 32-bit platforms.
Closed
LGTM 👍
stof
commented
Dec 18, 2015
make coveralls fails in the PHP 7 job on Travis though
derickr
added a commit
that referenced
this pull request
Dec 18, 2015
This was referenced Dec 21, 2015
Closed
make coveralls failure will be tracked in PHPC-522.
hppking
commented
Dec 23, 2015
/mongodb-1.1.1/src/bson.c:508: error: (Each undeclared identifier is reported only once/mnt/amp/mongodb-1.1.1/src/bson.c:508: error: for each function it appears in.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-285
This PR supersedes #136