-
Notifications
You must be signed in to change notification settings - Fork 211
PHPC-450: Fix test failures for MongoDB 3.2 #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
31f0124 to
f8068c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks (and all the same changes above) like something that needs to be split into two tests.
One on pre 3.2, and one 3.2+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'll split these and the fail point test to use the 3.0 test server.
819e8ce to
423fe8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no longer true?
It used to quite literally (and intentionally) result in an abort() to make sure the getmore failed completely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's possible that getMore itself aborts (I don't recall offhand). I thought this was referring to the PHP function itself and sending the configureFailPoint command, which certainly wasn't true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No no, the comment is referring to mongod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I revised the comment below. 👍
aa877b3 to
48323ea
Compare
LGTM
67f7d4c to
48323ea
Compare
This also entails a change to done/end_of_event cursor field assertions. These are internal libmongoc cursor fields and their values aren't relevant to the tests. In the future, we may consider removing them from the Cursor's dump output.
Since isMaster's response varies by server version, we can omit it from expected Server dump output.
The fail point used in this test does not yet support 3.2's getMore command, so this must be run on 3.0 (or earlier). See: SERVER-21831 This change also splits the test into query/command variants, corrects the title (which was apparently copied from cursor-getmore-004.phpt), and removes the use of data fixtures (small documents inserted within the test work just fine for its purposes).
48323ea to
b64561b
Compare
https://jira.mongodb.org/browse/PHPC-450