-
Notifications
You must be signed in to change notification settings - Fork 211
PHPC-2101: Default Binary constructor parameter to TYPE_GENERIC #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4fc3bdc to
8e500b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the CI failures for this PR. There looks to be another test that requires changes.
In the future, please make a point to come back to PRs on your own and check for failures. Anything that isn't already being tracked in JIRA (e.g. failing-on-waterfall label) should either be fixed or result in a new ticket (if the failure is truly unrelated to the PR).
tests/bson/bson-binary-002.phpt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This include is not necessary and can be removed. It was only included in bson-binary-001.phpt for some helper functions used within the test (e.g. fromPHP()).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
95a71cc to
0f60af2
Compare
acdc53e to
584766c
Compare
Seems I accidentally closed this PR when tried to solve conflict in phpstorm editor. new PR link is this #1362
Seems I accidentally closed this PR when tried to solve conflict in phpstorm editor.
In the future, you should just be able to re-open the pull request. If you don't have perms to do so, please reach out to @tom-selander.
@jmikola that's usually possible, but when force-pushing to a branch that's part of a closed pull request GotHub prevents one from re-opening said PR. I suspect that's what happened here.
Uh oh!
There was an error while loading. Please reload this page.
https://jira.mongodb.org/browse/PHPC-2101