-
Notifications
You must be signed in to change notification settings - Fork 1.5k
JAVA-279: Remove unused method #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
put is just delegating the call to its parent, so there is no need to define it.
BasicDBObject.append has the same implementation as its parent, so no need to repeat that.
Hi Arthur,
I'd like to consider this change in the 3.0.x branch, as we are currently in a code freeze for 2.12.0. Please consider opening a pull request on the new branch.
Thanks,
Jeff
Sounds good.. I will reopen this one against 3.0.x branch.
Maybe on the java driver we should follow the same pattern as the ruby driver where the development version is always master, and the current version 2.x is a branch. So contributors can freely open PRs against master.
Thoughts?
Normally that's what we do, but for the last six months or so we've really had two versions in active development: 2.12 and 3.0: the former is on master and the latter is on the 3.0.x branch (which really should have been named 3.x). Once 2.12 is stable its development will move to a 2.12.x branch and 3.0.x will be merged into master. Does that make sense?
👍 make 100% sense. thanks for the explanation.
Problem
BasicBSONObject.put()andBasicDBObject.append()are not necessary.Solution
Remove them
Why
BasicBSONObject.put() -> just calls the parent, so no need to override that method
BasicDBObject.append() -> Has the same code as the parent has, so no need to repeat that.
review @jyemin
[fix https://jira.mongodb.org/browse/JAVA-297]