-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Refactor tests, credential cache #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding @DmitryLukyanov to take first crack at this.
Edit: never mind. This is just refactoring, it seems.
driver-core/src/test/unit/com/mongodb/AbstractConnectionStringTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/AuthConnectionStringTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/AuthConnectionStringTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/MongoCredentialWithCache.java
Outdated
Show resolved
Hide resolved
I can't remember whether we intend to merge this or just close it.
9ee986c to
ad9b6c2
Compare
5536610 to
d562cb3
Compare
d562cb3 to
d46f122
Compare
driver-core/src/test/unit/com/mongodb/AuthConnectionStringTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but before merging, we need to make sure that the static check and tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but before merging, we need to make sure that the static check and tests pass.
Update: what an interesting duplication ☝️
Uh oh!
There was an error while loading. Please reload this page.
JAVA-4979
Refactoring for:
JAVA-4757