-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-2758 : Add Span<T> support to ObjectId #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for submitting this ticket @jasonkuo41
We are going to introduce support for Span in our serialization in CSHARP-5125.
It's scheduled after 3.0 release where we plan to introduce some architectural changes.
Closing this ticket as won't as do, as this will be part of CSHARP-5125.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the System.Memory package to the driver.
I hope that we could use this to further boost the performance of the driver with the new concept of Span and Memory introduced in .Net Core 2.1.
I'll add Span support to ObjectId for now, note that it may be possible to also add such support (and many other concepts introduced in System.Memory) towards BsonStream making it more performant in the future.