-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-5494: Deprecate Hedged Reads options #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we expose the hedged options in the readPreference options using the ReadPreferenceHedge class. Should we deprecate that as well?
I think we expose the hedged options in the readPreference options using the
ReadPreferenceHedgeclass. Should we deprecate that as well?
🤦 Thanks a lot for noticing, I'll take a look
5a155e2 to
0f21e7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm seeing all the warnings suppression is a bit ugly but I am not sure if there's another way to do this. We could add the suppression at the top of the file but I doubt we want to do that since it's best to know exactly what in a file you are suppressing than suppressing the whole file. cc @BorisDog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should stick with the current approach for warnings suppression. It's not the most convenient option, but is the safest. As we don't want to ignore things we don't want to ignore :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will using this constructor without the hedge parameter, generate an obsolete warning?
If so, we should probably provide a new ctor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it will generate an obsolete warning only when passing the hedge parameter.
No description provided.