-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Chore: apply ExplicitNullableParamTypeRector rule #3438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @zigzagdev, I appreciate your willingness to contribute to the project, but these changes are not relevant. I'm closing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule did not fix anything in the codebase. The explicit nullable params are already fixed by phpcs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to protect private properties with readonly, their usage is internal to this class.
Uh oh!
There was an error while loading. Please reload this page.
Checklist
=> I run rector test and attach my test results.
スクリーンショット 2025年08月05日 17 31 13
スクリーンショット 2025年08月05日 17 31 21