Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

PHPORM-320 Fix aliasing .id field path to ._id #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GromNaN merged 2 commits into mongodb:5.3 from GromNaN:PHPORM-320
Apr 15, 2025
Merged

Conversation

@GromNaN
Copy link
Member

@GromNaN GromNaN commented Apr 14, 2025 •
edited
Loading

Fix PHPORM-320
Fix #3351

Checklist

  • Add tests and ensure they pass

NickHuijgen reacted with thumbs up emoji
@GromNaN GromNaN added this to the 5.3 milestone Apr 14, 2025
@GromNaN GromNaN requested a review from a team as a code owner April 14, 2025 13:44
@GromNaN GromNaN requested a review from alcaeus April 14, 2025 13:44
- "12.*"
driver:
- 1
- 2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to change the default driver version that is tested to match the ruleset from #3347

alcaeus reacted with thumbs up emoji
'$or' => [
[
'$and' => [
['_id' => 10],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are flaws in the conversion if you use advanced queries. This transformation from id to _id is done in the compileWheres from the "column name":

// Compatibility with Eloquent queries that uses "id" instead of MongoDB's _id
if ($where['column'] === 'id') {
$where['column'] = '_id';
}

@GromNaN GromNaN merged commit af499af into mongodb:5.3 Apr 15, 2025
71 checks passed
@GromNaN GromNaN deleted the PHPORM-320 branch April 15, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /