-
Notifications
You must be signed in to change notification settings - Fork 1.4k
PHPORM-299 Enable PHPUnit 11 #3286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
349549b to
ebd3bab
Compare
ebd3bab to
cf2afc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defer to you if you'd like to use imported functions to replace the self:: prefixes for assertions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this a longstanding bug? I don't understand why a setUp() method should ever have been called during tearDown().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was added by bdb15c9#diff-ebd98368c673d521f95a7f40fff9ea0f20763fdd85dc6071fb7f710343804bcf, I can't explain.
Fix PHPORM-299
Ensures the
parent::tearDownmethod is always called to remove the error/exception handlers registered by Laravel.