Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOCSP-46230: atlas search index mgmt #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustagir merged 12 commits into mongodb:5.x from rustagir:DOCSP-46230-atlas-search-mgmt
Feb 25, 2025

Conversation

@rustagir
Copy link
Contributor

@rustagir rustagir commented Feb 11, 2025
edited
Loading

https://jira.mongodb.org/browse/DOCSP-46230

document how to create search and vs indexes with the Schema builder

STAGING:

  1. schema builder
  2. atlas search
  3. vector search

Checklist

  • Add tests and ensure they pass

@rustagir rustagir force-pushed the DOCSP-46230-atlas-search-mgmt branch from fed5cb5 to 77d77f5 Compare February 11, 2025 15:40
Copy link

@rachel-mack rachel-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some ordered lists:

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code sample would be better in a unit test, otherwise SGTM.

use Illuminate\Support\Facades\Schema;
use MongoDB\Laravel\Schema\Blueprint;

return new class extends Migration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the migration class is not actually displayed in the docs, you can move code snippets in up and down methods into unit tests that would validate them (ensure the index is correctly created) and deleted.

rustagir reacted with thumbs up emoji
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@rustagir rustagir merged commit 1974aec into mongodb:5.x Feb 25, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GromNaN GromNaN GromNaN left review comments

@norareidy norareidy norareidy approved these changes

@rachel-mack rachel-mack rachel-mack approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /