fixbug in pluck function #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

fuyuki0511 wants to merge 1 commit into mongodb:5.x from fuyuki0511:patch-1

Closed

fixbug in pluck function #3168

fuyuki0511 wants to merge 1 commit into mongodb:5.x from fuyuki0511:patch-1

Conversation

@fuyuki0511

Copy link

Contributor

@fuyuki0511 fuyuki0511 commented Oct 4, 2024

Fix bug in pluck function.
Cannot use object of type stdClass as array

Checklist

Add tests and ensure they pass

@fuyuki0511


 bugfix pluck

e51bc61

Fix bug in pluck function.
Cannot use object of type stdClass as array

@fuyuki0511 fuyuki0511 requested a review from a team as a code owner

October 4, 2024 08:21

@fuyuki0511 fuyuki0511 requested a review from GromNaN

October 4, 2024 08:21

GromNaN

GromNaN requested changes

Oct 4, 2024

View reviewed changes

Copy link

Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fuyuki0511 for contributing. I really appreciate.

Also, could you add a test in QueryBuilderTest. Something like this:

 public function testPluckObjectId()
 {
 DB::table('users')->insert([
 ['id' => $id = new ObjectId(), 'name' => 'Jane Doe', 'age' => 20],
 ]);
 $names = DB::table('users')->pluck('name', 'id')->toArray();
 $this->assertCount(1, $names);
 $this->assertArrayHasKey((string) $id, $names);
 $this->assertEquals([(string) $id => 'Jane Doe'], $names);
 }