-
Notifications
You must be signed in to change notification settings - Fork 1.4k
DOCSP-41336: documentmodel trait #3065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rustagir
merged 1 commit into
mongodb:4.6
from
rustagir:DOCSP-41336-documentmodel-trait
Jul 23, 2024
Merged
DOCSP-41336: documentmodel trait #3065
rustagir
merged 1 commit into
mongodb:4.6
from
rustagir:DOCSP-41336-documentmodel-trait
Jul 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongoKart
mongoKart
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple small changes but LGTM otherwise
GromNaN
GromNaN
reviewed
Jul 23, 2024
GromNaN
GromNaN
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@rustagir
rustagir
requested review from
alcaeus
and removed request for
alcaeus
July 23, 2024 14:24
@rustagir
rustagir
force-pushed
the
DOCSP-41336-documentmodel-trait
branch
from
July 23, 2024 14:27
14b3b3f to
eabde02
Compare
@rustagir
rustagir
force-pushed
the
DOCSP-41336-documentmodel-trait
branch
from
July 23, 2024 14:33
eabde02 to
8b0b270
Compare
This was referenced Jul 23, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Adds documentation for documentmodel trait
https://jira.mongodb.org/browse/DOCSP-41336
STAGING
Checklist