V5 #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

GromNaN wants to merge 10 commits into mongodb:4.8 from GromNaN:_id

Closed

V5 #3041

GromNaN wants to merge 10 commits into mongodb:4.8 from GromNaN:_id

Conversation

@GromNaN

Copy link

Member

@GromNaN GromNaN commented Jul 11, 2024 •

edited

Loading

Query Builder return stdClass: https://github.com/laravel/framework/blob/213a370b703592587bafcd52d38a0ad772ff7442/src/Illuminate/Database/Connection.php#L118C16-L118C25
Alias id for _id everywhere.
Don’t expose _id field: No _id attribute in Eloquent.
Always convert datetime to UTCDateTime: https://github.com/laravel/framework/blob/213a370b703592587bafcd52d38a0ad772ff7442/src/Illuminate/Database/Connection.php#L733-L734
Timezone : using Carbon instead of system timezone.

Checklist

Add tests and ensure they pass
Add an entry to the CHANGELOG.md file
Update documentation for new features

GromNaN and others added 6 commits

July 10, 2024 17:15

@GromNaN


 PHPORM-147 Make id an alias for _id

01ad545

@GromNaN


 Fix id alias in nested array

eee519b

@GromNaN @alcaeus


 Update CHANGELOG.md

fdfe31d

Co-authored-by: Andreas Braun <git@alcaeus.org>

@GromNaN


 Alias id to _id for sorting

715b68c

@GromNaN


 Apply id alias to sort and results

2c71461

@GromNaN


 Dont tuncate unused models

6a5124f

@github-actions github-actions bot added the docs label

Jul 11, 2024

github-advanced-security[bot]

github-advanced-security bot found potential problems

Jul 11, 2024

View reviewed changes

src/Session/SessionManager.php Outdated

{

public function __construct($app)

{

$this->app = $app;

Check failure

Code scanning / PHPStan

Access to an undefined property MongoDB\Laravel\Session\SessionManager::$app.

src/Session/SessionManager.php Outdated

{

$connection = $this->getMongoDBConnection();

$collection = $this->app['config']['session.table'];

Check failure

Code scanning / PHPStan

Access to an undefined property MongoDB\Laravel\Session\SessionManager::$app.

src/Session/SessionManager.php Outdated

$collection = $this->app['config']['session.table'];

$database = (string) $connection->getMongoDB();

Check failure

Code scanning / PHPStan

Call to method getMongoDB() on an unknown class MongoDB\Laravel\Session\Connection.

src/Session/SessionManager.php Outdated

$database = (string) $connection->getMongoDB();

$handler = new MongoDbSessionHandler($connection->getMongoClient(), $this->getMongoDBOptions($database, $collection));

Check failure

Code scanning / PHPStan

Call to method getMongoClient() on an unknown class MongoDB\Laravel\Session\Connection.

src/Session/SessionManager.php Outdated

* @return Connection

protected function getMongoDBConnection()

Check failure

Code scanning / PHPStan

Method MongoDB\Laravel\Session\SessionManager::getMongoDBConnection() has invalid return type MongoDB\Laravel\Session\Connection.

src/Session/SessionManager.php Outdated

protected function getMongoDBConnection()

{

$connection = $this->app['config']['session.connection'];

Check failure

Code scanning / PHPStan

Access to an undefined property MongoDB\Laravel\Session\SessionManager::$app.

src/Session/SessionManager.php Outdated

// The default connection may still be mysql, we need to verify if this connection

// is using the mongodb driver.

if (is_null($connection)) {

$default = $this->app['db']->getDefaultConnection();

Check failure

Code scanning / PHPStan

Access to an undefined property MongoDB\Laravel\Session\SessionManager::$app.

src/Session/SessionManager.php Outdated

if (is_null($connection)) {

$default = $this->app['db']->getDefaultConnection();

$connections = $this->app['config']['database.connections'];

Check failure

Code scanning / PHPStan

Access to an undefined property MongoDB\Laravel\Session\SessionManager::$app.

src/Session/SessionManager.php Outdated

}

return $this->app['db']->connection($connection);

Check failure

Code scanning / PHPStan

Access to an undefined property MongoDB\Laravel\Session\SessionManager::$app.

@GromNaN

V5

533d1b7

Query Builder return stdClass: https://github.com/laravel/framework/blob/213a370b703592587bafcd52d38a0ad772ff7442/src/Illuminate/Database/Connection.php#L118C16-L118C25
Alias id for _id everywhere
Don't expose _id field:
No _id attribute in Eloquent.
Deprecate reading and writing _id attribute.
Always convert datetime to UTCDateTime: https://github.com/laravel/framework/blob/213a370b703592587bafcd52d38a0ad772ff7442/src/Illuminate/Database/Connection.php#L733-L734
Timezone : using Carbon instead of system timezone.

@GromNaN GromNaN force-pushed the _id branch from 82847b7 to 533d1b7 Compare

July 12, 2024 08:03

GromNaN

GromNaN commented

Jul 12, 2024

View reviewed changes

src/Eloquent/Model.php

* @var string

protected $primaryKey = '_id';

Copy link

Member Author

@GromNaN GromNaN Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary key can keep the default value id, which is converted to _id by the query builder.

src/Query/Builder.php

// Fix for legacy support, converts the results to arrays instead of objects.

$options['typeMap'] = ['root' => 'array', 'document' => 'array'];

$options['typeMap'] = ['root' => 'object', 'document' => 'array'];

Copy link

Member Author

@GromNaN GromNaN Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major breaking change to meet Laravel's behavior: the query builder returns a stdClass object.

src/Queue/Failed/MongoFailedJobProvider.php Outdated

Comment on lines 9 to 10

/** @deprecated Use {@see DatabaseFailedJobProvider} */

class MongoFailedJobProvider extends DatabaseFailedJobProvider

Copy link

Member Author

@GromNaN GromNaN Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is no longer necessary as the Laravel class works out of the box thanks to the change of id field, automatic transformation of dates, and results returned as objects.

@GromNaN


 Remove class MongoFailedJobProvider

6a05d69

@GromNaN GromNaN force-pushed the _id branch from f6db985 to 6a05d69 Compare

July 12, 2024 08:11

GromNaN and others added 2 commits

July 15, 2024 12:08

@GromNaN


 Remove date conversion from results

0596b0a

@GromNaN @github-actions


 apply phpcbf formatting

d592241

@masterbater masterbater mentioned this pull request

Jul 19, 2024

[Feature Request] SessionServiceProvider for database #3022

Closed

@GromNaN GromNaN closed this

Aug 26, 2024

Labels

docs

1 participant

@GromNaN

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

V5 #3041

V5 #3041

Uh oh!

Conversation

@GromNaN GromNaN commented Jul 11, 2024 •

edited

Loading

Uh oh!

Checklist

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

@GromNaN GromNaN Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

@GromNaN GromNaN Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

@GromNaN GromNaN Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

V5 #3041

V5 #3041

Uh oh!

Conversation

@GromNaN GromNaN commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

@GromNaN GromNaN Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

@GromNaN GromNaN Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

@GromNaN GromNaN Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

@GromNaN GromNaN commented Jul 11, 2024 •

edited

Loading