-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added functionality to service provider #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a method which registers the mongodb connection as the database presence verifier for use with laravel Validation
Maybe we should add this to a separate service provider so that we can make this optional? This pull request currently breaks the code because Illuminate\Validation is not required in the composer.json.
Yes, that's probably a good idea, and I thought about it a bit some earlier. The only thing I wonder is whether one service provider should depend on another.
As for the break, the latest commit in the pull should have the proper dependency. That is strange.
I found a way to extend the original database manager instead of registering a new database manager. This pull request is probably no longer needed since it is now using app['db'] and not app['mongodb'] anymore.
Thanks!
...ountDocuments (mongodb#18) https://www.mongodb.com/docs/php-library/current/reference/method/MongoDBCollection-count/ Fix pass options to countDocuments for transaction session
...ountDocuments (#18) https://www.mongodb.com/docs/php-library/current/reference/method/MongoDBCollection-count/ Fix pass options to countDocuments for transaction session
Get database from dsn
Added a method which registers the mongodb connection as the database
presence verifier for use with laravel Validation