-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added withDefault support to EmbedsOne relation
#1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dylan-DutchAndBold
commented
Jun 15, 2018
Could really use this @jenssegers
lbrutti
commented
Dec 18, 2023
hello @alcaeus , i think this PR could be very useful...
As we try to stick to the features available in Eloquent, I think we can add this feature.
Would you like to open a new pull request, adding tests also.
lbrutti
commented
Dec 19, 2023
I invoke @axlon for PR reopening and testing
This feature request is tracker in Jira: PHPORM-128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to add support for Laravel's withDefault function to the EmbedsOne relation, this function provides a way for 1 on 1 relations to define default data if no related model can be found.
Laravel documentation on this method: https://laravel.com/docs/5.6/eloquent-relationships (search for 'default models')