This repository was archived by the owner on May 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
COMPASS-3485 Parsing of expression clause #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherlihy
aherlihy
suggested changes
Apr 15, 2019
@aherlihy
aherlihy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks right but I would add a second test for using $expr in a nested expression, and not just top-level
aherlihy
aherlihy
approved these changes
Apr 15, 2019
aherlihy
aherlihy
approved these changes
Apr 15, 2019
@alenakhineika
alenakhineika
deleted the
COMPASS-3485-expr-query-validation
branch
April 15, 2019 10:35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter expression was not valid when using $expr to query documents.
Example:
{"$expr": {"$gt": ["$sold", "$total"]}}